aho135 commented on code in PR #19372:
URL: https://github.com/apache/druid/pull/19372#discussion_r3149723750


##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorIOConfig.java:
##########
@@ -78,7 +79,8 @@ public KafkaSupervisorIOConfig(
       @JsonProperty("idleConfig") IdleConfig idleConfig,
       @JsonProperty("stopTaskCount") Integer stopTaskCount,
       @Nullable @JsonProperty("emitTimeLagMetrics") Boolean emitTimeLagMetrics,
-      @Nullable @JsonProperty("serverPriorityToReplicas") Map<Integer, 
Integer> serverPriorityToReplicas
+      @Nullable @JsonProperty("serverPriorityToReplicas") Map<Integer, 
Integer> serverPriorityToReplicas,
+      @Nullable @JsonProperty("boundedStreamConfig") BoundedStreamConfig 
boundedStreamConfig

Review Comment:
   Yup, the idea is for `taskDuration` and `completionTimeout` to work as they 
currently do. If a task exceeds the configured `taskDuration` but the offset 
range hasn't been fully processed yet then `isOffsetAtOrBeyond` will return 
false and the Supervisor will spin up a new task starting from the checkpointed 
metadata



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to