abhishekrb19 commented on code in PR #19372:
URL: https://github.com/apache/druid/pull/19372#discussion_r3140862918
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorIOConfig.java:
##########
@@ -78,7 +79,8 @@ public KafkaSupervisorIOConfig(
@JsonProperty("idleConfig") IdleConfig idleConfig,
@JsonProperty("stopTaskCount") Integer stopTaskCount,
@Nullable @JsonProperty("emitTimeLagMetrics") Boolean emitTimeLagMetrics,
- @Nullable @JsonProperty("serverPriorityToReplicas") Map<Integer,
Integer> serverPriorityToReplicas
+ @Nullable @JsonProperty("serverPriorityToReplicas") Map<Integer,
Integer> serverPriorityToReplicas,
+ @Nullable @JsonProperty("boundedStreamConfig") BoundedStreamConfig
boundedStreamConfig
Review Comment:
How do the bounds interplay with the supervisor’s behavior with other
properties like `taskDuration`, `completionTimeout`, etc.?
I suppose if the bounds are too wide, tasks would still roll over and all
existing properties would be honored as-is. The only additional behavioral
change is when this optional config is specified and the end sequence numbers
are reached, the supervisor eventually moves to a terminal `COMPLETED` state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
