github-advanced-security[bot] commented on code in PR #19372:
URL: https://github.com/apache/druid/pull/19372#discussion_r3139750629
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -230,6 +234,37 @@
groupId,
startingSequences,
unfilteredStartingSequencesForSequenceName,
+ null, // endSequences - null for streaming mode
+ minimumMessageTime,
+ maximumMessageTime,
+ exclusiveStartSequenceNumberPartitions,
+ generateSequenceName(
+ unfilteredStartingSequencesForSequenceName == null
+ ? startingSequences
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [SeekableStreamSupervisorSpec.getDataSchema](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/560)
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java:
##########
@@ -2609,6 +2614,24 @@
{
return new LagStats(0, 0, 0);
}
+
+ @Override
+ protected boolean isOffsetAtOrBeyond(String current, String target)
+ {
+ return Long.parseLong(current) >= Long.parseLong(target);
+ }
+
+ @Override
+ protected String createPartitionIdFromString(String partitionIdString)
+ {
Review Comment:
## CodeQL / Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11133)
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java:
##########
@@ -2609,6 +2614,24 @@
{
return new LagStats(0, 0, 0);
}
+
+ @Override
+ protected boolean isOffsetAtOrBeyond(String current, String target)
+ {
+ return Long.parseLong(current) >= Long.parseLong(target);
+ }
+
+ @Override
+ protected String createPartitionIdFromString(String partitionIdString)
+ {
Review Comment:
## CodeQL / Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11134)
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorTestBase.java:
##########
@@ -328,6 +328,24 @@
{
return partitionNumbers;
}
+
+ @Override
+ protected boolean isOffsetAtOrBeyond(String current, String target)
+ {
+ return Long.parseLong(current) >= Long.parseLong(target);
Review Comment:
## CodeQL / Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11131)
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java:
##########
@@ -3273,6 +3299,24 @@
{
return false;
}
+
+ @Override
+ protected boolean isOffsetAtOrBeyond(String current, String target)
+ {
+ return Long.parseLong(current) >= Long.parseLong(target);
+ }
+
+ @Override
+ protected String createPartitionIdFromString(String partitionIdString)
+ {
+ return partitionIdString;
+ }
+
+ @Override
Review Comment:
## CodeQL / Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11135)
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorTestBase.java:
##########
@@ -328,6 +328,24 @@
{
return partitionNumbers;
}
+
+ @Override
+ protected boolean isOffsetAtOrBeyond(String current, String target)
+ {
+ return Long.parseLong(current) >= Long.parseLong(target);
Review Comment:
## CodeQL / Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11132)
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java:
##########
@@ -3273,6 +3299,24 @@
{
return false;
}
+
+ @Override
+ protected boolean isOffsetAtOrBeyond(String current, String target)
+ {
+ return Long.parseLong(current) >= Long.parseLong(target);
+ }
+
+ @Override
+ protected String createPartitionIdFromString(String partitionIdString)
+ {
+ return partitionIdString;
+ }
+
+ @Override
Review Comment:
## CodeQL / Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11136)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
