aho135 commented on code in PR #19372:
URL: https://github.com/apache/druid/pull/19372#discussion_r3165138497
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -4255,6 +4418,23 @@ private OrderedSequenceNumber<SequenceOffsetType>
getOffsetFromStorageForPartiti
}
Review Comment:
@FrankChen021 Thinking through this one a bit more, the validation approach
is a bit tricky. It's not straightforward to tell if the existing metadata is
from the bounded Supervisor itself (in which case starting from the metadata
would be the correct behavior) or if it's from a previous Supervisor.
One approach we can take is that if the metadata offset falls within the
configured start/end offsets then use that, otherwise fall back to startOffset.
This does run the risk of partial ingestion of the specified range though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
