github-actions[bot] commented on code in PR #69591:
URL: https://github.com/apache/doris/pull/69591#discussion_r4374189049
##########
regression-test/suites/query_p0/test_array_with_single_row_max_than_uint16.groovy:
##########
@@ -51,11 +36,24 @@ suite("test_array_with_single_row_max_than_uint16",
"query") {
)
"""
// prepare data
- qt_sql """
- insert into ${testTable} select * from local(
- "file_path" = "${outFilePath}/arr_max.orc",
- "backend_id" = "${be_id}",
- "format" = "orc");"""
+ String bucket = getS3BucketName()
+ String key =
"regression/local_tvf_migration/${UUID.randomUUID()}/arr_max.orc"
+ def s3Client = getS3Client()
+ s3Client.putObject(bucket, key, new File(context.config.dataPath,
"query_p0/arr_max.orc"))
Review Comment:
[P2] Preserve Azure support in the migrated fixture loads
With the supported `s3Source="azure"` configuration,
`Config.fillDefaultConfig()` sets `s3Provider="Azure"` and
`s3Endpoint="azure-endpoint"`, but `Suite.getS3Client()` (lines 1441–1446)
always builds an `AmazonS3Client` using that raw endpoint and AWS credentials.
This unconditional `putObject` therefore cannot upload to the configured Azure
storage, so this suite and the same migration in
`types/complex_types/map_uniq_with_local_tvf.groovy:39-40` fail before their
existing count/value assertions. Use provider-aware fixture upload, cleanup,
and TVF properties, or another fixture-loading path that works across the
supported providers. This is a separate provider failure from the previously
fixed complex-ORC Stream Load rejection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
