OIiveirra commented on code in PR #69591:
URL: https://github.com/apache/doris/pull/69591#discussion_r4374426900
##########
regression-test/suites/datatype_p0/uuid/test_uuid_csv_schema.groovy:
##########
@@ -19,27 +19,17 @@
suite("test_uuid_csv_schema", "p0,external") {
sql "SET enable_sql_cache = false"
sql "SET enable_query_cache = false"
- String localPath = context.config.otherConfigs.get('uuidLocalExportPath')
String token = UUID.randomUUID().toString()
def sources = [:]
for (String kind : ['values', 'invalid']) {
File fixture = new File(context.dataPath,
"test_data/uuid_external_${kind}.csv")
- if (localPath != null) {
- File target = new File("${localPath}_${token}_${kind}.csv")
- java.nio.file.Files.copy(fixture.toPath(), target.toPath())
- String path =
"${context.config.otherConfigs.get('uuidLocalTvfPath')}_${token}_${kind}.csv"
- sources[kind] = """LOCAL('file_path'='${path}',
- 'backend_id'='${(sql 'SHOW
BACKENDS')[0][0]}','format'='csv',
- 'column_separator'=',','csv_schema'='id:int;u:uuid')"""
- } else {
- String bucket = context.config.otherConfigs.get('s3BucketName')
- String key = "uuid_csv_schema/${token}/${kind}.csv"
- getS3Client().putObject(bucket, key, fixture)
- sources[kind] = """S3('uri'='s3://${bucket}/${key}','format'='csv',
- 'column_separator'=',','csv_schema'='id:int;u:uuid',
-
's3.endpoint'='${getS3Endpoint()}','s3.region'='${getS3Region()}',
-
's3.access_key'='${getS3AK()}','s3.secret_key'='${getS3SK()}')"""
- }
+ String bucket = context.config.otherConfigs.get('s3BucketName')
+ String key = "uuid_csv_schema/${token}/${kind}.csv"
+ getS3Client().putObject(bucket, key, fixture)
Review Comment:
Confirmed: removing the LOCAL fixture overrides exposes the existing
AWS-only fallback on Azure in these three UUID suites on master and branch-4.2.
We are deferring the additional Azure uploader/TVF adaptation for these suites:
this PR is scoped to unconditional LOCAL rejection without an enable flag, and
restoring the LOCAL fallback would contradict that change. This remains a
non-blocking test compatibility limitation and is not claimed as fixed.
Resolving this discussion as a scope decision; no additional code change or
review/build retrigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
