github-actions[bot] commented on code in PR #69591:
URL: https://github.com/apache/doris/pull/69591#discussion_r4373809923
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/LocalTableValuedFunction.java:
##########
@@ -63,6 +63,8 @@ public class LocalTableValuedFunction extends
ExternalFileTableValuedFunction {
private boolean sharedStorage = false;
public LocalTableValuedFunction(Map<String, String> properties) throws
AnalysisException {
+ checkAccess();
Review Comment:
[P2] Adapt the remaining LOCAL-dependent regression cases
Two existing suites still assume the earlier LOCAL behavior.
`regression-test/suites/account_p0/test_local_tvf_privilege.groovy:39` expects
`ADMIN/OPERATOR` for its SELECT-only user's LOCAL/FILE SELECT and EXPLAIN
cases. This call now throws `LOCAL TVF is disabled` before `checkAuth`, so the
first case fails the framework's exception-substring assertion.
Also,
`regression-test/suites/datatype_p0/uuid/test_uuid_export.groovy:22-81` still
chooses LOCAL readback when `uuidLocalExportPath` is configured; after a
successful local export, its reload now fails here. Update the account
expectation and retire or migrate the UUID suite's local-mode branch while
preserving its existing S3 export/reload coverage. These are separate surviving
test cases from the previously reported sink-fixture and metadata-glob tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
