github-actions[bot] commented on code in PR #69591:
URL: https://github.com/apache/doris/pull/69591#discussion_r4373704266


##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/LocalTableValuedFunction.java:
##########
@@ -63,6 +63,8 @@ public class LocalTableValuedFunction extends 
ExternalFileTableValuedFunction {
     private boolean sharedStorage = false;
 
     public LocalTableValuedFunction(Map<String, String> properties) throws 
AnalysisException {
+        checkAccess();

Review Comment:
   [P2] Adapt the existing Parquet metadata local-glob tests
   
   This constructor is also used by 
`ParquetMetadataTableValuedFunction.expandSingleGlob()` for local wildcard 
expansion. The unchanged 
`regression-test/suites/external_table_p0/tvf/test_parquet_meta_tvf.groovy` 
still executes `order_qt_parquet_file_metadata_local_glob` (lines 270–276), 
expecting a count of 3 for `/*meta.parquet`. It now throws `LOCAL TVF is 
disabled` before expansion, so the existing suite fails. Its no-match wildcard 
test (lines 516–523) also still expects `failed to glob`. Adapt these two cases 
to the new rejection or migrate their coverage to remote metadata paths, 
preserving the suite's remaining S3/HDFS and exact-path assertions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to