github-actions[bot] commented on code in PR #69593:
URL: https://github.com/apache/doris/pull/69593#discussion_r4372016395
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -659,6 +660,10 @@ private Plan
bindTVFTableSink(MatchingContext<UnboundTVFTableSink<Plan>> ctx) {
"INSERT INTO TVF only supports local/s3/hdfs, but got: " +
tvfName);
}
+ if (tvfName.equals(LocalTableValuedFunction.NAME)) {
+ LocalTableValuedFunction.checkAccess(ctx.connectContext);
Review Comment:
[P2] Opt the existing local sink unit test into this gate
With the new false default,
`BindTVFTableSinkTest.duplicateOutputNamesKeepDistinctPositions()` now throws
`LOCAL TVF is disabled` from its `PlanChecker.analyze(...)` call before
checking the two output ExprIds. It constructs a local sink but never enables
this flag, and Surefire uses a separate JVM per test class
(`reuseForks=false`), so the opt-in in the new tests cannot carry over. Set and
restore `Config.enable_local_tvf` in that existing test, as the new tests do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
