OIiveirra opened a new pull request, #69593:
URL: https://github.com/apache/doris/pull/69593
### What problem does this PR solve?
Issue Number: N/A
Related PR: #69591, #69528
Problem Summary:
LOCAL TVF is enabled by default, so constructing a LOCAL query can reach
file discovery before an operator opts in. Add startup-only
enable_local_tvf=false and check FE admission before property parsing, backend
selection and discovery. FILE TVF with local storage delegates to the same
entry point. Explicit opt-in retains the existing storage implementation and
requires ADMIN/OPERATOR. Explicit LOCAL INSERT and EXPLAIN INSERT use the same
admission check before sink property validation.
Existing regression deployments that exercise LOCAL opt in explicitly. This
PR provides default-disable mitigation. Enabled storage-path sandbox hardening
remains separate work.
### Release note
LOCAL TVF and FILE TVF with local storage are disabled by default. To enable
them, set enable_local_tvf=true in fe.conf on every query-serving FE and
restart those FEs. The configuration is not runtime-mutable. Enabled LOCAL
admission requires ADMIN/OPERATOR.
### Check List (For Author)
- Test
- [x] Unit Test — focused coverage added; not executed.
- [x] Regression test — coverage added; not executed.
- [ ] Manual test
- [ ] No need to test
Validation: Checkstyle passed for all 5 changed Java files, and diff
whitespace checks passed. Unit/regression execution and local code review have
not been performed for this new head. This PR remains draft pending runtime
validation.
- Behavior changed:
- [ ] No.
- [x] Yes. LOCAL requires explicit startup opt-in and FE admission.
- Does this need documentation?
- [ ] No.
- [x] Yes. Configuration description and release note included;
operator-documentation follow-up remains pending.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
