github-actions[bot] commented on code in PR #69593:
URL: https://github.com/apache/doris/pull/69593#discussion_r4374192136
##########
regression-test/suites/types/complex_types/map_uniq_with_local_tvf.groovy:
##########
@@ -45,11 +34,24 @@ suite("map_uniq_with_local_tvf", "p0") {
"disable_auto_compaction" = "false"
); """
- qt_sql """
- insert into ${table_name} select * from local(
- "file_path" = "${outFilePath}/mm.orc",
- "backend_id" = "${be_id}",
- "format" = "orc");"""
+ String bucket = getS3BucketName()
+ String key = "regression/local_tvf_migration/${UUID.randomUUID()}/mm.orc"
+ def s3Client = getS3Client()
+ s3Client.putObject(bucket, key, new File(context.config.dataPath,
"types/complex_types/mm.orc"))
Review Comment:
[P2] Make migrated fixture uploads support the Azure provider
With the supported `s3Source="azure"` regression configuration
(`Config.groovy:590,775-776`), this unconditional upload uses
`Suite.getS3Client()`, which always constructs an AWS `AmazonS3Client` with
`BasicAWSCredentials` (`Suite.groovy:1430-1436`). It issues an S3 request
against Azure Blob instead of using the Azure client/authentication path, so
the suite fails before its map assertions. The identical upload in
`test_array_with_single_row_max_than_uint16.groovy:41-42` also fails before the
array assertions. Previously both loaded provider-independent local fixtures.
Use a provider-aware upload/read path or another fixture loader that preserves
these tests for Azure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
