yiguolei commented on code in PR #11598: URL: https://github.com/apache/doris/pull/11598#discussion_r941912108
########## be/src/olap/reader.cpp: ########## @@ -613,15 +613,14 @@ Status TabletReader::_init_delete_condition(const ReaderParams& read_params) { } auto delete_init = [&]() -> Status { - return _delete_handler.init(_tablet_schema, _tablet->delete_predicates(), + return _delete_handler.init(_tablet_schema, read_params.delete_predicates, read_params.version.second, this); }; if (read_params.reader_type == READER_ALTER_TABLE) { return delete_init(); } Review Comment: If not need acquire tablet lock here, then I think we do not need distinguish alter table and others. 620-623 could be deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org