zhannngchen commented on code in PR #11598:
URL: https://github.com/apache/doris/pull/11598#discussion_r940820715
##########
be/src/vec/exec/volap_scanner.cpp:
##########
@@ -106,13 +106,11 @@ Status VOlapScanner::prepare(
<< ", backend=" << BackendOptions::get_localhost();
return Status::InternalError(ss.str());
}
- }
- }
- {
- // Initialize tablet_reader_params
- RETURN_IF_ERROR(
- _init_tablet_reader_params(key_ranges, filters, bloom_filters,
function_filters));
+ // Initialize tablet_reader_params
+ RETURN_IF_ERROR(_init_tablet_reader_params(key_ranges, filters,
bloom_filters,
Review Comment:
@Gabriel39 could you help to review this PR? The comment of method
`_init_tablet_reader_params` says it requires caller to hold a read lock of
tablet, but our code actually not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
