Gabriel39 commented on code in PR #11598:
URL: https://github.com/apache/doris/pull/11598#discussion_r940867347
##########
be/src/vec/exec/volap_scanner.cpp:
##########
@@ -106,13 +106,11 @@ Status VOlapScanner::prepare(
<< ", backend=" << BackendOptions::get_localhost();
return Status::InternalError(ss.str());
}
- }
- }
- {
- // Initialize tablet_reader_params
- RETURN_IF_ERROR(
- _init_tablet_reader_params(key_ranges, filters, bloom_filters,
function_filters));
+ // Initialize tablet_reader_params
+ RETURN_IF_ERROR(_init_tablet_reader_params(key_ranges, filters,
bloom_filters,
Review Comment:
That comment seems outdated and you can remove it directly.
##########
be/src/vec/exec/volap_scanner.cpp:
##########
@@ -195,6 +193,10 @@ Status VOlapScanner::_init_tablet_reader_params(
std::inserter(_tablet_reader_params.function_filters,
_tablet_reader_params.function_filters.begin()));
+ std::copy(_tablet->delete_predicates().cbegin(),
_tablet->delete_predicates().cend(),
Review Comment:
Would this cause a wrong delete predicate working on a new-arrival rowset?
If we start a query with scanning rowset A (with a delete predicate), and
just copy its delete predicate here, but a new rowset B is inserted meanwhile,
would this delete predicate work on rowset B?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
