zhannngchen commented on code in PR #11598:
URL: https://github.com/apache/doris/pull/11598#discussion_r941929060
##########
be/src/olap/merger.cpp:
##########
@@ -41,6 +41,10 @@ Status Merger::merge_rowsets(TabletSharedPtr tablet,
ReaderType reader_type,
reader_params.reader_type = reader_type;
reader_params.rs_readers = src_rowset_readers;
reader_params.version = dst_rowset_writer->version();
+ reader_params.delete_predicates = tablet->delete_predicates();
+ std::copy(tablet->delete_predicates().cbegin(),
tablet->delete_predicates().cend(),
+ std::inserter(reader_params.delete_predicates,
+ reader_params.delete_predicates.begin()));
Review Comment:
1. compaction don't need to care new added delete predicates, it's useless
for this compaction.
2. only compaction would remove delete predicates, so it also don't need to
worry other thread to concurrently remove the delete predicates related with
input rowset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
