[
https://issues.apache.org/jira/browse/CASSANDRA-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952783#comment-17952783
]
Stefan Miklosovic edited comment on CASSANDRA-20328 at 5/20/25 7:29 AM:
------------------------------------------------------------------------
[~andrew.tolbert] all of what you mentioned in 1) should be indeed moved to
tools. There are two cases when a tool can be used
a) when we test a tool itself
b) when we test something else and executing a tool is just a mean to get there
For a) it is a no-brainer and should be moved to tools. For b) you see that for
sstableloader we have "server side tool" which is not depending on the driver.
So I would expect that, similarly, for FQL tool, if we really need it in
server, could not FQL also work without the driver? If sstableloader did it,
why fqltool could not? BulkLoader in tools is just a wrapper around
SSTableLoader. BulkLoader is using driver because it needs to know the details
about server but "outside" of server. So similar abstraction might be done for
FQL.
was (Author: smiklosovic):
[~andrew.tolbert] all of what you mentioned in 1) should be indeed moved to
tools. There are two cases when a tool can be used
a) when we test a tool itself
b) when we test something else and executing a tool is just a mean to get there
For a) it is a no-brainer and should be moved to tools. For b) you see that for
sstableloader we have "server side tool" which is not depending on the driver.
So I would expect that, similarly, for FQL tool, if we really need it in
server, could not FQL also work without a driver? If sstableloader did it, why
fqltool could not? BulkLoader in tools is just a wrapper around SSTableLoader.
BulkLoader is using driver because it needs to know the details about server
but "outside" of server. So similar abstraction might be done for FQL.
> Migrate sstableloader code to its own tools directory
> -----------------------------------------------------
>
> Key: CASSANDRA-20328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20328
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
> Reporter: Andy Tolbert
> Assignee: Andy Tolbert
> Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Attachments: CASSANDRA-0413-20328_ci_summary.html,
> CASSANDRA-20328-511-0_ci_summary.html, CASSANDRA-20328-515-0_ci_summary.html,
> CASSANDRA-20328-515-0_results_details.tgz, CASSANDRA-20328-test_results.html,
> ci_summary_tolbertam_CASSANDRA-20328_238.html,
> results_details_tolbertam_CASSANDRA-20328_238.tar.xz
>
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> Akin to fqltool and stress, we should move sstableloader to its own tools
> directory. This is needed to decouple the java driver as a dependency from
> server code ([CASSANDRA-20326]).
> For backwards compatibility reasons, we should retain {{bin/sstableloader}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
