[
https://issues.apache.org/jira/browse/CASSANDRA-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940384#comment-17940384
]
Stefan Miklosovic edited comment on CASSANDRA-20328 at 4/2/25 3:06 PM:
-----------------------------------------------------------------------
I took a look a it looks quite nice. I would like to have an opinion of other
people, most preferably from [~mck]. To summarize - Andy created a separate
class path for sstableloader. When we remove dependency on driver in
cassandra-all, then we will add that dependency to sstableloader pom. The
result is that sstableloader can depend on a driver independently from what is
in server / it will be decoupled in that regard completely. Please keep in mind
that we will very likely use the same approach in case of FQL and stress, this
is just the first one.
related PR for CCM here: https://github.com/apache/cassandra-ccm/pull/787
was (Author: smiklosovic):
I took a look a it looks quite nice. I would like to have an opinion of other
people, most preferably from [~mck]. To summarize - Andy created a separate
class path for sstableloader. When we remove dependency on driver in
cassandra-all, then we will add that dependency to sstableloader pom. Please
keep in mind that we will very likely use the same approach in case of FQL and
stress, this is just the first one.
related PR for CCM here: https://github.com/apache/cassandra-ccm/pull/787
> Migrate sstableloader code to its own tools directory
> -----------------------------------------------------
>
> Key: CASSANDRA-20328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20328
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
> Reporter: Andy Tolbert
> Assignee: Andy Tolbert
> Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Attachments: CASSANDRA-20328-test_results.html
>
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Akin to fqltool and stress, we should move sstableloader to its own tools
> directory. This is needed to decouple the java driver as a dependency from
> server code ([CASSANDRA-20326]).
> For backwards compatibility reasons, we should retain {{bin/sstableloader}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
