[
https://issues.apache.org/jira/browse/CASSANDRA-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952593#comment-17952593
]
Stefan Miklosovic edited comment on CASSANDRA-20328 at 5/19/25 1:09 PM:
------------------------------------------------------------------------
I just moved that test to tools and it just works fine. [~andrew.tolbert] Would
you mind to go over that and move them under sstable loader tests? There are
two so far I could find:
SSTableLoaderEncryptionOptionsTest and GuardrailBulkLoadEnabledTest.
BulkLoader should not be used in tests for server. If we need to load SSTables
as part of the tests, we can use server-side SSTableLoader. If used in e.g.
distributed tests, a tester can call StorageService#bulkLoad methods. This
server-specific functionality does not use Datastax driver.
was (Author: smiklosovic):
I just moved that test to tools and it just works fine. [~andrew.tolbert] Would
you mind to go over that are move them under sstable loader tests? There are
two so far I could find:
SSTableLoaderEncryptionOptionsTest and GuardrailBulkLoadEnabledTest.
BulkLoader should not be used in tests for server. If we need to load SSTables
as part of the tests, we can use server-side SSTableLoader. If used in e.g.
distributed tests, a tester can call StorageService#bulkLoad methods. This
server-specific functionality does not use Datastax driver.
> Migrate sstableloader code to its own tools directory
> -----------------------------------------------------
>
> Key: CASSANDRA-20328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20328
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
> Reporter: Andy Tolbert
> Assignee: Andy Tolbert
> Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Attachments: CASSANDRA-0413-20328_ci_summary.html,
> CASSANDRA-20328-511-0_ci_summary.html, CASSANDRA-20328-515-0_ci_summary.html,
> CASSANDRA-20328-test_results.html,
> ci_summary_tolbertam_CASSANDRA-20328_238.html,
> results_details_tolbertam_CASSANDRA-20328_238.tar.xz
>
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> Akin to fqltool and stress, we should move sstableloader to its own tools
> directory. This is needed to decouple the java driver as a dependency from
> server code ([CASSANDRA-20326]).
> For backwards compatibility reasons, we should retain {{bin/sstableloader}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
