[
https://issues.apache.org/jira/browse/CASSANDRA-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952580#comment-17952580
]
Benedict Elliott Smith edited comment on CASSANDRA-20328 at 5/19/25 12:19 PM:
------------------------------------------------------------------------------
I don't use (and don't intend to use) that script, which is a good thing as it
helps catch problems like this. Looking at this more closely, the problem is
that you have coupled the project's unit test directory to the
tools/sstableloader/src directory which should not happen - there is a separate
tools/X/test directory for these tests. The affected tests should really be
moved there, or else some other mechanism should be used to break this
dependency (otherwise, why have we even encapsulated it elsewhere?).
was (Author: benedict):
I don't use (and don't intend to use) that script, which is a good thing as it
helps catch problems like this. Looking at this more closely, the problem is
that you have coupled the project's unit test directory to the
tools/sstableloader/src directory which should not happen - there is a separate
tools/X/test directory for these tests. The affected tests should really be
moved there, or else some other mechanism should be used to break this
dependency.
> Migrate sstableloader code to its own tools directory
> -----------------------------------------------------
>
> Key: CASSANDRA-20328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20328
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
> Reporter: Andy Tolbert
> Assignee: Andy Tolbert
> Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Attachments: CASSANDRA-0413-20328_ci_summary.html,
> CASSANDRA-20328-511-0_ci_summary.html, CASSANDRA-20328-515-0_ci_summary.html,
> CASSANDRA-20328-test_results.html,
> ci_summary_tolbertam_CASSANDRA-20328_238.html,
> results_details_tolbertam_CASSANDRA-20328_238.tar.xz
>
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> Akin to fqltool and stress, we should move sstableloader to its own tools
> directory. This is needed to decouple the java driver as a dependency from
> server code ([CASSANDRA-20326]).
> For backwards compatibility reasons, we should retain {{bin/sstableloader}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
