Hello, here are some feedbacks :
I suggest you should create a namespace for the code of the game ('cause you want to show clojure good coding practices, as well as good coding conventions, won't you ;-) Could it make sense to use even fewer def's than currently ? I guess it could be made not mandatory to have apple, snake, as global vars ? And the JFrame too ? It could be great to have just defn's (and defstruct's and defmacro's), and a single defn entry point for starting the game ? HTH, -- Laurent Mark Volkmann wrote: > I've written a new version of the snake program that uses a more > literate style and therefore, to my eyes, calls for far fewer > comments. I think this code is very readable. Check it out at > http://www.ociweb.com/mark/programming/ClojureLiterateSnake.html. > Feedback is welcomed! > > The most controversial thing about this code is probably my use of def > to change the state of the snake and the apple. It's not yet clear to > me that using atoms is needed here, but I need to think about that > more. > > This version has some features that weren't in the original such as: > - automatically turning the snake in the clockwise direction when a > board edge is reached > - changing the color of the snake to black when it overlaps itself > - announcing a win when the length of the snake reaches 10 > - automatically restarting the game after an overlap or a win > > -- > R. Mark Volkmann > Object Computing, Inc. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en -~----------~----~----~----~------~----~------~--~---