chandlerc added a comment. In https://reviews.llvm.org/D28047#629824, @mehdi_amini wrote:
> In https://reviews.llvm.org/D28047#629746, @rnk wrote: > > > How about standardizing on -disable-llvm-passes instead of > > -disable-llvm-optzns? I never liked "optzns" and can't remember how to > > spell it. Also, this flag disables LLVM instrumentation passes (ASan) as > > well as optimization passes, so I think -disable-llvm-passes is the better > > name. > > > I agree with that. > To be friendly with developers/users we could print an error mentioning to > use `-disable-llvm-passes` when they try to use `-disable-llvm-optzns` (which > we accept as a `-mllvm -disable-llvm-optzns` hardcoded in the driver by the > way). I only have a mild preference for how we spell the name based on the fact that i've told people to use -disable-llvm-optzns for years. If we want to go with ...-passes, fine with me. I'll probably just add an alias so that you can use either spelling, but change the tests to consolidate on whichever spelling we end up with. SG? I can regenerate the patch if desired, but it'll just be a lot of perl... https://reviews.llvm.org/D28047 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
