fpetrogalli added inline comments.
================
Comment at: llvm/lib/TargetSupport/CMakeLists.txt:2
+
+set(LLVM_TARGET_DEFINITIONS ${CMAKE_SOURCE_DIR}/lib/Target/RISCV/RISCV.td)
+
----------------
tmatheson wrote:
> Here `RISCVTargetSupportTableGen` depends on files in `lib/Target/RISCV`,
> meaning the folder structure doesn't reflect the dependency graph and it
> looks like a circular dependency. It would be cleaner to keep the
> `TargetParser` data out of `lib/Target` in e.g.
> `llvm/lib/TargetSupport/RISCVTargetInfo.td`. If it is needed in `RISCV.td` it
> could be included from there.
The generator needs the field `Name` which is stored in the class
`ProcessorModel`. Moving instances of `ProcessorModel` out of
`lib/Target/RISCV/RISCV.td` seems quite a major change, not just a matter of
including a file. I'll give it a go anyway and report back.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137517/new/
https://reviews.llvm.org/D137517
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
