craig.topper added inline comments.
================ Comment at: llvm/lib/Target/RISCV/CMakeLists.txt:18 tablegen(LLVM RISCVGenSubtargetInfo.inc -gen-subtarget) +tablegen(LLVM RISCVTargetParserDef.inc -gen-riscv-target-def) ---------------- Should not this only be in the CMakeLists for the TargetSupport library? ================ Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:9 +// +// This tablegen backend emits an assembly printer for the current target. +// Note that this is currently fairly skeletal, but will grow over time. ---------------- This comment says assembly printer but that’s not what this file is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/D137517 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
