malaperle added a comment. In D54781#1306872 <https://reviews.llvm.org/D54781#1306872>, @sammccall wrote:
> This is great! > > I'm slightly nervous - the way we've extended the protocol with > `textDocument/switchSourceHeader` is pretty hard to extend, itself (since the > response is a string directly). > This is only tangentially related to this patch, the same issue exists with > Theia (I thought it was version locked to clangd, but it seems not to be). > > I think this is fine. We may want to revise the protocol to wrap the URI in a > struct (which should be soon!). Since VSCode plugin can be assumed to be > newer than clangd, we can make it accept both versions. I think it does make the to revise it. I don't think anything outside Theia and this vscode extension uses it. This might be a good opportunity to make it a proper protocol extension as explained here: https://github.com/Microsoft/language-server-protocol/blob/master/contributing.md#how-to-create-a-protocol-extension Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54781/new/ https://reviews.llvm.org/D54781 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
