ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

lgtm

Could you run clang-format on the changed lines?



================
Comment at: clangd/clients/clangd-vscode/package.json:81
+                "command": "clangd-vscode.switchheadersource",
+                "title": "C/C++: Switch between Source/Header"
+            }
----------------
and objc?


================
Comment at: clangd/clients/clangd-vscode/src/extension.ts:55
             protocol2Code: (value: string) =>
                 vscode.Uri.file(realpathSync(vscode.Uri.parse(value).fsPath))
         }
----------------
We might want to share the logic for converting protocol URI to vscode URI.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54781



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to