sammccall added a comment.

This is great!

I'm slightly nervous - the way we've extended the protocol with 
`textDocument/switchSourceHeader` is pretty hard to extend, itself (since the 
response is a string directly).
This is only tangentially related to this patch, the same issue exists with 
Theia (I thought it was version locked to clangd, but it seems not to be).

I think this is fine. We may want to revise the protocol to wrap the URI in a 
struct (which should be soon!). Since VSCode plugin can be assumed to be newer 
than clangd, we can make it accept both versions.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54781



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to