ilya-biryukov added a comment.
Overall LG, merely stylistic NITs.
================
Comment at: clangd/clients/clangd-vscode/src/extension.ts:69
+ const docIdentifier = TextDocumentIdentifier.create(uri.toString());
+ clangdClient.sendRequest(SwitchSourceHeaderRequest.type,
docIdentifier).then(sourceUri => {
+ if (sourceUri !== undefined) {
----------------
Maybe use async/await to improve readabiity? I.e.
```
/*...*/push(registerCommand('...', async() => {
// ...
const sourceUri = await
clangdClient.sendRequest(SwitchSourceHeaderRequest.type, docIdentifier);
if (!sourceUri) {
return;
}
const doc = await // ....
}
```
================
Comment at: clangd/clients/clangd-vscode/src/extension.ts:70
+ clangdClient.sendRequest(SwitchSourceHeaderRequest.type,
docIdentifier).then(sourceUri => {
+ if (sourceUri !== undefined) {
+
vscode.workspace.openTextDocument(vscode.Uri.parse(sourceUri)).then(doc =>
vscode.window.showTextDocument(doc));
----------------
Maybe do `if (!sourceUri)` to use consistent style with the first check in the
lambda (i.e. `if (!uri)`)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54781
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
