On Mon, 28 Oct 2024 23:16:17 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use #error for unknown CPU >> - Restore PLATFORM_CHECK_DEPRECATION > > make/modules/jdk.accessibility/Lib.gmk line 34: > >> 32: >> 33: >> ############################################################################## >> 34: ## Build libjavaaccessbridge > > Is double `##` intentional? Well, yes and no. :-) I just copied the pattern I used elsewhere as a header to mark the output library name for `SetupJdkLibrary`. Now that you say this, I wonder why I started using `##`. Most of the places, but not all, use the double hash sign. Let's do this `##` for now as well, and then maybe I do another round of cross-makefile consistency and replace them all with single `#`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1820945684
