On Mon, 28 Oct 2024 19:17:54 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 >> Port_](https://openjdk.org/jeps/479). >> >> This is the summary of JEP 479: >>> Remove the source code and build support for the Windows 32-bit x86 port. >>> This port was [deprecated for removal in JDK >>> 21](https://openjdk.org/jeps/449) with the express intent to remove it in a >>> future release. > > src/hotspot/os/windows/os_windows.cpp line 136: > >> 134: #define __CPU__ amd64 >> 135: #else >> 136: #define __CPU__ unknown > > Should this be just `#error Unknown CPU`? +1 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1820365629
