On Mon, 28 Oct 2024 18:58:51 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 >> Port_](https://openjdk.org/jeps/479). >> >> This is the summary of JEP 479: >>> Remove the source code and build support for the Windows 32-bit x86 port. >>> This port was [deprecated for removal in JDK >>> 21](https://openjdk.org/jeps/449) with the express intent to remove it in a >>> future release. > > make/modules/jdk.accessibility/Launcher.gmk line 56: > >> 54: $(eval $(call SetupJdkExecutable, BUILD_JACCESSINSPECTOR, \ >> 55: NAME := jaccessinspector, \ >> 56: EXTRA_SRC := \ > > I might be missing something here. Original block has `SRC` parameter, do we > not need it anymore? > > Similar thing in `BUILD_JACCESSWALKER` and `BUILD_LIBJAVAACCESSBRIDGE` below. I think it was needed when the name didn't match the src dir, due to the `$1` suffix, but now we don't have that complication anymore. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1819883595
