On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 > Port_](https://openjdk.org/jeps/479). > > This is the summary of JEP 479: >> Remove the source code and build support for the Windows 32-bit x86 port. >> This port was [deprecated for removal in JDK >> 21](https://openjdk.org/jeps/449) with the express intent to remove it in a >> future release. Cursory review, sometimes with my 32-bit x86 maintainer hat on :) make/autoconf/platform.m4 line 669: > 667: AC_ARG_ENABLE(deprecated-ports, > [AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@], > 668: [Suppress the error when configuring for a deprecated port > @<:@no@:>@])]) > 669: if test "x$OPENJDK_TARGET_OS" = xwindows && test > "x$OPENJDK_TARGET_CPU" = xx86; then Can you just hollow `PLATFORM_CHECK_DEPRECATION` out, without removing? I think I am going to use it for full 32-bit port deprecation. make/modules/jdk.accessibility/Launcher.gmk line 56: > 54: $(eval $(call SetupJdkExecutable, BUILD_JACCESSINSPECTOR, \ > 55: NAME := jaccessinspector, \ > 56: EXTRA_SRC := \ I might be missing something here. Original block has `SRC` parameter, do we not need it anymore? Similar thing in `BUILD_JACCESSWALKER` and `BUILD_LIBJAVAACCESSBRIDGE` below. src/hotspot/os/windows/os_windows.cpp line 136: > 134: #define __CPU__ amd64 > 135: #else > 136: #define __CPU__ unknown Should this be just `#error Unknown CPU`? src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp line 523: > 521: > 522: extern "C" int SpinPause () { > 523: #ifdef AMD64 Weird that SpinPause is not implemented on Win64, but oh well. This whole SpinPause mess should be arch-specific, not OS/Arch specific, probably. ------------- PR Review: https://git.openjdk.org/jdk/pull/21744#pullrequestreview-2399951993 PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1819593526 PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1819596530 PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1819620086 PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1819631224
