On Wed, 16 Oct 2024 16:19:51 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:

>> Please review this change that adds a new test root `docs` dedicated to 
>> testing the documentation, which has been a work in progress for a while. 
>> Tests for links, encoding, HTML, accessibility will be later added in 
>> following PRs. 
>> 
>> We also define a new make target `test-docs` meant for local use and depends 
>> on the docs.
>> This also adds the necessary configurations needed at Oracle.
>> 
>> This patch includes a test `TestDocs` which serves to show developers how 
>> they are meant to resolve the docs to test them, I want to include it 
>> temporarily until better tests are added later.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   ADD TEST_DEPS when calling tests using test-$1
>   
>   drop docs/req.flg

After the last change, I think we now cover everything that is needing for this 
PR.

I will file followup RFEs after this one is integrated to:

-Calculate tests dependencies automatically 
-Setup GHA support (this one isn't a priority until the doc tests are ready to 
be integrated)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21272#issuecomment-2417372315

Reply via email to