On Wed, 16 Oct 2024 13:02:32 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following PRs. >> >> We also define a new make target `test-docs` meant for local use and depends >> on the docs. >> This also adds the necessary configurations needed at Oracle. >> >> This patch includes a test `TestDocs` which serves to show developers how >> they are meant to resolve the docs to test them, I want to include it >> temporarily until better tests are added later. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > Remove usage of TIDY_HOME, replace with TIDY > Revert changes to RunTestsPrebuiltSpec.gmk > Add TEST_DEPS to InitSupport.gmk At this point, it is simplest to just add the `$(TEST_DEPS)` dependency there: $(foreach t, $(filter-out test-make%, $(ALL_TEST_TARGETS)), $(eval $t: jdk-image test-image $(TEST_DEPS))) $(foreach t, $(ALL_EXPLODED_TEST_TARGETS), $(eval $t: exploded-image test-image $(TEST_DEPS))) We will need to revisit this anyway if we want to calculate TEST_DEPS automatically for certain test targets. test/docs/req.flg line 1: > 1: echo_file test/TEST.properties What is this for? I see that there is a similar file for the `jdk` test suite, but it says `echo_file test/TEST.ROOT`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21272#issuecomment-2417200640 PR Review Comment: https://git.openjdk.org/jdk/pull/21272#discussion_r1803365332
