On Sun, Aug 03, 2025 at 03:13:07AM +0100, Gavin Smith wrote: > TRANSLITERATE_FILE_NAMES and ADD_TRANSLITERATED_REDIRECTION_FILES is > very similar: > > * TRANSLITERATE_FILE_NAMES: main output in files with transliterated > names; create redirection files with non-transliterated names > > * ADD_TRANSLITERATED_REDIRECTION_FILES: main output in files with > non-transliterated names; create redirection files with transliterated names. > > I know you (Patrice) said that ADD_TRANSLITERATED_REDIRECTION_FILES would > be a temporary measure, but we should question whether we even need it > in the first place. It could be enough for manuals to use > TRANSLITERATE_FILE_NAMES if they want links to work to the manual with > transliterated names.
I agree that it is quite similar. On the one hand I agree that it can cause confision, on the other hand, I liked the idea to have two options, one for the short term to get the same behaviour as before and another for the explicit setting of transliteration. I'll do what you decide. > ~ > > Also, I found a bug. There doesn't seem to be validity checking for > the values of customisation variables given on the command line: > > ../../tta/perl/texi2any.pl --html test.texi -c > ADD_TRANSLITERATED_REDIRECTION_FILES= > BUG: ADD_TRANSLITERATED_REDIRECTION_FILES: not an integer: > ERROR: ADD_TRANSLITERATED_REDIRECTION_FILES unexpected conf error > BUG: ADD_TRANSLITERATED_REDIRECTION_FILES: not an integer: > BUG: ADD_TRANSLITERATED_REDIRECTION_FILES: not an integer: > ERROR: ADD_TRANSLITERATED_REDIRECTION_FILES unexpected conf error > BUG: ADD_TRANSLITERATED_REDIRECTION_FILES: not an integer: > ERROR: ADD_TRANSLITERATED_REDIRECTION_FILES unexpected conf error > test.texi: warning: must specify a title with a title command or @top > test.texi:11: warning: no HTML cross-references entry found for `ext' > > I guess that if an invalid value is given on the command line, it should > be detected and not used as the value, rather than causing bugs and errors > to be reported throughout the program. I fixed this, but not by adding more checks, to the contrary, to be more like Perl, I set to 0 if the string is empty, and to 1 otherwise, since it is true in Perl. Not exactly the same as comparison won't fail in C with the value set to 1, while it will fail in Perl with the value set to a string and trigger a warning. -- Pat
