Follow-up Comment #15, bug #66675 (group groff): [comment #12 comment #12:] > I'm not convinced of your reasoning here, in part because (as far as I > recall), I haven't touched the code that interprets the "charset" sections of > font description files.
I did _touch_ it (and indeed forgot about it)...
commit 4c08cda8ae420dc8fe48932e81f0565768ec20d9
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
AuthorDate: Wed Jan 3 17:48:58 2024 -0600
Commit: G. Branden Robinson <g.branden.robin...@gmail.com>
CommitDate: Thu Jan 4 12:26:00 2024 -0600
[libgroff, troff]: Refactor.
* src/include/unicode.h: Rename function `check_unicode_name` to
`valid_unicode_code_sequence` and update comments to better explain
what it actually does. The validity of "u1234_5678" in addition to
"u1234" was undocumented and not even implied.
* src/libs/libgroff/unicode.cpp (check_unicode_name): Rename this...
(valid_unicode_code_sequence): ...to this.
* src/libs/libgroff/font.cpp (glyph_to_unicode)
* src/roff/troff/input.cpp (token::next, map_composite_character)
(composite_glyph_name): Update call sites. Make comparisons to null
pointers explicit.
Also fix code style nits. Update editor aid comments; drop old-style
Emacs file-local variable setting. Drop comment that had no purpose
other than to mark the end of the file since the editor aid comments
also fulfill that role. Wrap long lines. Annotate null pointers with
`nullptr` comment to ease any future transition to C++11, which defines
it as a keyword.
...but it really was a refactoring, and did not change behavior, as
illustrated by the patch in comment #14 not requiring a change to _libgroff_.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?66675>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
