On Sun, Oct 5, 2014 at 5:05 PM, Norihiro Tanaka <nori...@kcn.ne.jp> wrote: > Jim Meyering <j...@meyering.net> wrote: >> Thank you. >> I have added a test case to your post-transit_state buffer-length >> checking patch, and shrank the eolbytes buffer by one byte, now >> that I see this patch prevents the overrun. Here's the patch I'll >> push later today: > > Thanks. Could you also add a test case in a patch attached with a > following URL to it? As it's result wrong, should be tested. > > http://debbugs.gnu.org/cgi/bugreport.cgi?msg=17;bug=18580
Sorry I missed that message. The commit log text is a good explanation, and deserves to be a comment in the code, so I have written a patch in your name to factor out those two duplicate blocks, also adding your commit log message as a comment. Since this commit is in your name, I would appreciate a careful review and an explicit "ACK" (or suggestion for correction or improvement) from you before I push it. I will also add your test in a separate upcoming commit.
0001-dfa-factor-out-a-new-nontrivial-block-of-duplicated-.patch
Description: Binary data