On Mon, Oct 6, 2014 at 8:52 AM, Norihiro Tanaka <nori...@kcn.ne.jp> wrote: > Jim Meyering <j...@meyering.net> wrote: >> Sorry I missed that message. >> The commit log text is a good explanation, and deserves to be >> a comment in the code, so I have written a patch in your name >> to factor out those two duplicate blocks, also adding your commit >> log message as a comment. Since this commit is in your name, >> I would appreciate a careful review and an explicit "ACK" (or >> suggestion for correction or improvement) from you before I push it. >> >> I will also add your test in a separate upcoming commit. > > Thanks for the review and the suggestion. Sorry, I want to replace a > macro definition to a inilne function, but I have no idea...
If you don't want your name on it, let me know. I listed you as the author mainly for the comment. I too would have preferred an inline function, but feel that the number of parameters would be too large. Think of this as a stopgap measure to avoid risk of divergence in those two blocks of code.
