>>> On 19.06.19 at 22:11, <andrew.coop...@citrix.com> wrote: > .rodata.cst* sections are used for mergable constant data, and the clang/llvm > 8 toolchain has been observed to create .rodata.cst8 in a default Xen build.
Neither this nor ... > Unfortunately, this section (and its .init counterpart) aren't captured by > Xen's linker globs, and end up as orphaned sections. ... this are problems on their own. The issue is if these sections end up first in the binary (which, as we all appear to agree, should never have happened). > Generalise the data globbing to pick up cst and future special sections. I'm a little wary of this, and had in the past specifically avoided adding "too wide" a glob pattern: There's a small risk of covering a section that's meant to be covered elsewhere. The observation of the issue with the Arm side change is an example of such. Therefore I'd prefer if we could get away with just adding .init.rodata.cst* and .rodata.cst*. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
