On 19/06/2019 22:30, Julien Grall wrote: > Hi, > > On 6/19/19 9:11 PM, Andrew Cooper wrote: >> * Drop .gnu.warning. Xen, not being a library, has no need for >> __attribute__((__warning__("str"))) and isn't liable to ever gain >> such >> annotations for link time warnings. > > What if this is introduced?
Then attempting to link Xen as a library against another object file won't emit the custom linker warning. Its main use is for phase-out of problematic API's, but for Xen (and other standalone binaries) we do that by replacing problematic functions entirely. > How do we catch it? Code review? ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel