Hi Andrew,

On 6/19/19 9:11 PM, Andrew Cooper wrote:
Neither of these should live in .data

  * .data.schedulers is only ever read, so is moved into .rodata
  * CONSTRUCTORS is only ever read, and only at boot, so is moved to beside
    .init.rodata

Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
---
CC: Jan Beulich <jbeul...@suse.com>
CC: Wei Liu <w...@xen.org>
CC: Roger Pau Monné <roger....@citrix.com>
CC: Stefano Stabellini <sstabell...@kernel.org>
CC: Julien Grall <julien.gr...@arm.com>
---
  xen/arch/arm/xen.lds.S | 11 ++++++-----
  xen/arch/x86/xen.lds.S | 11 ++++++-----
  2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index 31d74a8..2b44e5d 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -66,6 +66,11 @@ SECTIONS
         *(.data.param)
         __param_end = .;
+ . = ALIGN(POINTER_ALIGN);

The alignment is going to be different on arm32 now. Please explain in the commit message why this is fine.

+       __start_schedulers_array = .;
+       *(.data.schedulers)
+       __end_schedulers_array = .;
+

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to