>>> On 23.08.18 at 11:47, <paul.durr...@citrix.com> wrote: > The name 'iommu_use_hap_pt' suggests that that P2M table is in use as the > domain's IOMMU pagetable which, prior to this patch, is not strictly true > since the macro did not test whether the domain actually has IOMMU > mappings.
Hmm, I would never have implied "has IOMMU mappings" from this variable name. To me it has always been "use HAP page tables for IOMMU if an IOMMU is in use". The code change looks sane, but I'm not sure it is a clear improvement. Hence I wonder whether you have a need for this change in subsequent patches which goes beyond what you say above. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
