> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 04 September 2018 11:38 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Julien Grall <julien.gr...@arm.com>; Andrew Cooper > <andrew.coop...@citrix.com>; Wei Liu <wei.l...@citrix.com>; George > Dunlap <george.dun...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; > Jun Nakajima <jun.nakaj...@intel.com>; Kevin Tian > <kevin.t...@intel.com>; Stefano Stabellini <sstabell...@kernel.org>; xen- > devel <xen-devel@lists.xenproject.org>; Konrad Rzeszutek Wilk > <konrad.w...@oracle.com>; Tim (Xen.org) <t...@xen.org> > Subject: Re: [PATCH v6 04/14] iommu: don't domain_crash() inside > iommu_map/unmap_page() > > >>> On 23.08.18 at 11:47, <paul.durr...@citrix.com> wrote: > > --- a/xen/common/grant_table.c > > +++ b/xen/common/grant_table.c > > @@ -1154,6 +1154,7 @@ map_grant_ref( > > } > > if ( err ) > > { > > + domu_crash(ld); > > double_gt_unlock(lgt, rgt); > > You crash the domain with both locks held here, but ... > > > @@ -1406,7 +1407,10 @@ unmap_common( > > double_gt_unlock(lgt, rgt); > > > > if ( err ) > > + { > > + domu_crash(ld); > > rc = GNTST_general_error; > > + } > > ... outside of the locked region here. I think the latter is fine, and > hence the former should be changed.
Sure. Will do. > > With that > Reviewed-by: Jan Beulich <jbeul...@suse.com> > Thanks, Paul > Jan > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
