>>> On 23.08.18 at 11:47, <paul.durr...@citrix.com> wrote:
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -1154,6 +1154,7 @@ map_grant_ref(
> }
> if ( err )
> {
> + domu_crash(ld);
> double_gt_unlock(lgt, rgt);
You crash the domain with both locks held here, but ...
> @@ -1406,7 +1407,10 @@ unmap_common(
> double_gt_unlock(lgt, rgt);
>
> if ( err )
> + {
> + domu_crash(ld);
> rc = GNTST_general_error;
> + }
... outside of the locked region here. I think the latter is fine, and
hence the former should be changed.
With that
Reviewed-by: Jan Beulich <jbeul...@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
