On 08/01/2025 7:16 am, Jan Beulich wrote: > On 07.01.2025 18:18, Petr Beneš wrote: >> On Tue, Jan 7, 2025 at 5:46 PM Jan Beulich <jbeul...@suse.com> wrote: >>> Hmm ... Instead of you touching the bit in every one of the case blocks, >>> I was expecting you to clear the bit ahead of the switch(), accepting a >>> double update in the p2m_access_r_pw case. >> I did consider it, but ultimately didn't like the double-update. >> Similarly, the switch-case above does also set each bit in the >> "case-s" individually. But I understand it's more justified there. > Right - it's setting them to all different combinations each time. > >> However, if you insist, I'll fix it. > Please do; it helps readability quite a bit in this case, imo.
I agree. These "writes" are just bit operations on a single register. The compiler is pretty good at rearranging such logic. Seeing as this is the only issue, I'm happy to fix on commit? ~Andrew
