On 10.09.2024 20:08, Andrew Cooper wrote: > On 10/09/2024 3:40 pm, Jan Beulich wrote: >> All read accesses are rejected by the ->accept handler, while writes >> bypass the bulk of the function body. Drop the dead code, leaving an >> assertion in the read handler. >> >> A number of other static items (and a macro) are then unreferenced and >> hence also need (want) dropping. The same applies to the "latch" field >> of the state structure. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > In the read handler, I don't think we need to fill in ~0. A while back, > we had the base layer fill this in, to fix stack rubble leaks.
It fills something, yes, but 0, not ~0. Plus I was trying to make obvious by just looking at the function that nothing unexpected can happen even in release builds, if the function was really called in error. > Either way, > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> Thanks. Jan
