On 10/09/2024 3:40 pm, Jan Beulich wrote: > All read accesses are rejected by the ->accept handler, while writes > bypass the bulk of the function body. Drop the dead code, leaving an > assertion in the read handler. > > A number of other static items (and a macro) are then unreferenced and > hence also need (want) dropping. The same applies to the "latch" field > of the state structure. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
In the read handler, I don't think we need to fill in ~0. A while back, we had the base layer fill this in, to fix stack rubble leaks. Either way, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> I'm sad that we called map & unmap for every byte in multi-byte accesses. Good riddance.
