On 10.09.2024 19:47, Andrew Cooper wrote:
> On 10/09/2024 3:40 pm, Jan Beulich wrote:
>> @@ -498,19 +483,17 @@ static bool cf_check stdvga_mem_accept(
>>
>> spin_lock(&s->lock);
>>
>> - if ( p->dir == IOREQ_WRITE && p->count > 1 )
>> + if ( p->dir != IOREQ_WRITE || p->count > 1 )
>> {
>> /*
>> * We cannot return X86EMUL_UNHANDLEABLE on anything other then the
>> * first cycle of an I/O. So, since we cannot guarantee to always be
>> * able to send buffered writes, we have to reject any multi-cycle
>> - * I/O.
>> + * I/O. And of course we have to reject all reads, for not being
>> + * able to service them.
>> */
>> goto reject;
>> }
>> - else if ( p->dir == IOREQ_READ &&
>> - (true || !s->stdvga) )
>> - goto reject;
>
> Before, we rejected on (WRITE && count) or READ, and I think we still do
> afterwards given the boolean-ness of read/write. However, the comment
> is distinctly less relevant.
>
> I think we now just end up with /* Only accept single writes. */ which
> matches with with shuffling these into the bufioreq ring.
Fine with me. As usually I'm commenting rather too little, I was fearing
I'd remove too much if I shrunk the comment like this.
Jan
