On 13.05.2024 15:40, Elias El Yandouzi wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -851,6 +851,8 @@ int arch_domain_create(struct domain *d, > > psr_domain_init(d); > > + mapcache_domain_init(d);
This new placement is re-done right away in the next patch. To me this is another hint at it wanting considering to deal with the idle domain here as well, right away. > --- a/xen/arch/x86/domain_page.c > +++ b/xen/arch/x86/domain_page.c > @@ -82,11 +82,11 @@ void *map_domain_page(mfn_t mfn) > #endif > > v = mapcache_current_vcpu(); > - if ( !v || !is_pv_vcpu(v) ) > + if ( !v ) > return mfn_to_virt(mfn_x(mfn)); While I don't mind this and ... > @@ -187,14 +187,14 @@ void unmap_domain_page(const void *ptr) > ASSERT(va >= MAPCACHE_VIRT_START && va < MAPCACHE_VIRT_END); > > v = mapcache_current_vcpu(); > - ASSERT(v && is_pv_vcpu(v)); > + ASSERT(v); ... this change being done already here, I don't think that's necessary. Nor is it really related to what the subject and (so far at least) description say is being done here. In which case the description wants to at least mention why the adjustments are pulled ahead earlier than where they're strictly needed. Jan
