On 14.05.2024 11:40, Roger Pau Monné wrote: > On Mon, May 13, 2024 at 01:40:34PM +0000, Elias El Yandouzi wrote: >> @@ -53,6 +55,8 @@ enum fixed_addresses { >> FIX_PV_CONSOLE, >> FIX_XEN_SHARED_INFO, >> #endif /* CONFIG_XEN_GUEST */ >> + FIX_PMAP_BEGIN, >> + FIX_PMAP_END = FIX_PMAP_BEGIN + NUM_FIX_PMAP, > > This would better have > > #ifdef CONFIG_HAS_PMAP > > guards?
That's useful only when the option can actually be off in certain configurations, isn't it? Jan