On Tue, May 14, 2024 at 11:20:21AM +0200, Roger Pau Monné wrote: > On Mon, May 13, 2024 at 01:40:33PM +0000, Elias El Yandouzi wrote: > > From: Hongyan Xia <hongy...@amazon.com> > > diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h > > index 7561297a75..9d4f1f2d0d 100644 > > --- a/xen/include/xen/mm.h > > +++ b/xen/include/xen/mm.h > > @@ -167,6 +167,13 @@ extern unsigned long max_page; > > extern unsigned long total_pages; > > extern paddr_t mem_hotplug; > > > > +extern bool opt_directmap; > > + > > +static inline bool has_directmap(void) > > +{ > > + return opt_directmap; > > This likely wants: > > return IS_ENABLED(CONFIG_HAS_SECRET_HIDING) && opt_directmap;
Er, sorry, this is wrong, should be: return !IS_ENABLED(CONFIG_HAS_SECRET_HIDING) || opt_directmap; Roger.